This repository has been archived by the owner on Apr 29, 2024. It is now read-only.
Fix exit code of parallel_rspec #40
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without `English` being required, `$CHILD_STATUS` in line 26 is undefined and thus evaluates to `nil`, and `nil.to_i` is `0`. So parallel_rspec always returned `0` -> success, even when specs failed.
|
do you think you can fix circleCI? |
|
feel free to push fixes. I can release the new version of gem to rubygems once we bump it ;) |
iGEL
force-pushed
the
master
branch
3 times, most recently
from
7bbe2fd to
4940c56
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without
Englishbeing required,$CHILD_STATUSin line 26 isundefined and thus evaluates to
nil, andnil.to_iis0. Soparallel_rspec always returned
0-> success, even when specsfailed.